BUG: crosstab with duplicate column or index labels #37997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osstab_dup_names
arw2019
commented
Nov 22, 2020
pandas/core/reshape/pivot.py
Outdated
| Given a list of row or column names, creates a mapper of unique names to | ||
| column/row names. | ||
|
|
||
| Parameters |
There was a problem hiding this comment.
arw2019
commented
Nov 22, 2020
pandas/core/reshape/pivot.py
Outdated
| raise ValueError("values cannot be used without an aggfunc.") | ||
| # We create our own mapping of row and columns names | ||
| # to prevent issues with duplicate columns/row names. GH Issue: #22529 | ||
| shared_col_row_names = set(rownames).intersection(set(colnames)) |
There was a problem hiding this comment.
arw2019
changed the title
jreback
requested changes
Nov 26, 2020
| def _build_names_mapper( | ||
| rownames: List[str], colnames: List[str] | ||
| ) -> Tuple[Dict[str, str], List[str], Dict[str, str], List[str]]: | ||
| def get_duplicates(names): |
There was a problem hiding this comment.
can you add a doc-string here
jreback
added
Bug
and removed
Needs Review
|
Green + addressed comments |
jreback
approved these changes
Nov 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking up from #28474
cc @jreback in case this can go in in time for 1.2