-
-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: crosstab with duplicate column or index labels #37997
Merged
Merged
Changes from 54 commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
a748ccd
BUG: Check for duplicate names in columns and index when calling cros…
cuchoi c5430ab
Updated test for duplicated names in crosstab
cuchoi 5762bb6
Flake8 compliance
cuchoi 989bd5a
Black formatting
cuchoi 672bd4b
Creates name mapping to overcome duplicated columns issues in pd.cros…
cuchoi 1b67514
Removed debug prints
cuchoi 4f2fa86
Removed empty line
cuchoi fbff182
Improved comments
cuchoi 6071db5
String manipulation compatible with <3.6
cuchoi 3d9c632
Replaced custom method with _value_counts_arraylike
cuchoi d27233f
Resort imports
cuchoi 478d8dc
Merge branch 'master' of https://github.com/pandas-dev/pandas into cr…
cuchoi 1828a36
Merged master
cuchoi 3e9333d
Added docstring and type hints to _build_names_mapper
cuchoi fe6f7fd
Sorted imports
cuchoi 9f4a00a
Added types to unique_names
cuchoi 788ac2b
Updated tests
cuchoi 354a180
Merge branch 'master' into crosstab_dup_names
cuchoi d938a96
Sorted imports
cuchoi d60308c
Sorted imports
cuchoi b759073
Merged master
cuchoi cf63d4c
Merge remote-tracking branch 'upstream/master' into crosstab_dup_names
cuchoi 94e8175
Merged master
cuchoi c6ccab1
Merge remote-tracking branch 'upstream/master' into crosstab_dup_names
cuchoi 142ade0
Merged master
cuchoi 710ab63
Merged master
cuchoi cad2dea
Improved comment
cuchoi f2741db
Merged master
cuchoi f0261e9
Updated tests
cuchoi 2733c17
Removed pd. reference in tests
cuchoi f1b19a6
Removed pd. reference in tests
cuchoi d475edd
Merged to master
cuchoi 85e010b
Added Set import from typing
cuchoi 558493f
Merge remote-tracking branch 'upstream/master' into crosstab_dup_names
cuchoi 3ed74d9
Renamed duplicated row/col names test
cuchoi e5c6cd9
Added what's new entry
cuchoi d16b840
Merge remote-tracking branch 'upstream/master' into crosstab_dup_names
simonjayhawkins 32aa475
Moved release note to 1.2
cuchoi 820945e
Merged master
cuchoi dc1d5c5
Updated reference to value_counts_arraylike
cuchoi 0b002da
Merge branch 'master' into crosstab_dup_names
cuchoi 42d130b
merge with upstream/master
arw2019 86c6ff1
consolidate test
arw2019 bbf7757
comments + cleanup
arw2019 575e7cd
Merge branch 'master' of https://github.com/pandas-dev/pandas into GH…
arw2019 00f6ca3
rewrite _build_names_mapper for rownames, colnames args
arw2019 2a41491
simplify _build_names_mapper
arw2019 975af3e
rename row_names->rownames, col_names->colnames for consistency
arw2019 33f76c8
rewrite whatsnew
arw2019 c9a11dd
rename vars in _build_names_mapper
arw2019 a849884
typing
arw2019 0c44679
more typing
arw2019 11616a0
Merge branch 'master' of https://github.com/pandas-dev/pandas into GH…
arw2019 84ca716
Merge branch 'master' of https://github.com/pandas-dev/pandas into GH…
arw2019 b59cbc7
Merge branch 'master' of https://github.com/pandas-dev/pandas into GH…
arw2019 e42011a
review comment: add docstring
arw2019 5ca0447
more on docstring
arw2019 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a doc-string here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done