BUG: Fixed regression in rolling.skew and rolling.kurt modifying object #38909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Regression
jreback
requested changes
Jan 3, 2021
pandas/_libs/window/aggregations.pyx
Outdated
| @@ -504,6 +504,7 @@ def roll_skew(ndarray[float64_t] values, ndarray[int64_t] start, | |||
| ) | |||
| output = np.empty(N, dtype=float) | |||
| min_val = np.nanmin(values) | |||
| values_copy = np.empty(N, dtype=float) | |||
There was a problem hiding this comment.
why don't you simply copy values to begin with? then all of these additions are not needed
There was a problem hiding this comment.
Was not sure which would be faster. When we do a copy, we have to touch the values again in case of
min_val - mean_val > -1e5
Changed it
jreback
approved these changes
Jan 4, 2021
|
thanks @phofl |
|
@meeseeksdev backport 1.2.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 4, 2021
…nd rolling.kurt modifying object
jreback
pushed a commit
that referenced
this pull request
Jan 4, 2021
….kurt modifying object (#38945)
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
1 task
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffAlternative would be np.copy before releasing gil. In this case we would have to touch values_copy twice in case of
min_val - mean_val > -1e5