Remove xlrd benchmark after xlrd was updated to 2.0.1 on conda-forge #39077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively we could remove this benchmark |
jreback
requested changes
Jan 9, 2021
|
Done |
|
Have to backport this too. |
phofl
changed the title
jreback
approved these changes
Jan 9, 2021
|
great, backporting as well to avoid 1.2.x CI failures |
|
@jreback greenish based on the changes here. Azure will take a while because of the new master commits |
|
thanks @phofl |
|
@meeseeksdev backport 1.2.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 10, 2021
…dated to 2.0.1 on conda-forge
jreback
pushed a commit
that referenced
this pull request
Jan 10, 2021
….0.1 on conda-forge (#39078) Co-authored-by: patrick <61934744+phofl@users.noreply.github.com>
| @@ -40,7 +40,7 @@ def time_write_excel(self, engine): | |||
|
|
|||
| class ReadExcel: | |||
|
|
|||
| params = ["xlrd", "openpyxl", "odf"] | |||
| params = ["openpyxl", "odf"] | |||
There was a problem hiding this comment.
We could also rather keep this, but with writing an xls file (in addition to the xlsx file) to read with xlrd?
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is pinning here the right thing to do in environment.yml?
cc @jreback