Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Styler.set_sticky fix the names rows 2/2 #42799

Merged
merged 12 commits into from
Aug 7, 2021

Conversation

attack68
Copy link
Contributor

@attack68 attack68 commented Jul 29, 2021

BUG:
In 1.3.0/1.3.1 set_sticky did not handle well the names of column/index headers.
This overall bug fix makes sure those cells are well handled.
Should be backported to 1.3.2

Before any Fixes After 2 of 2 fixes
Index / No Names
before fixes index no names after fixes index no names
Index + Names
before fixes index names after fixes index names
MultIndex / No Names
before fixes multiindex no names after fixes multiindex no names
MultIndex + Names
before fixes multiindex names after fixes multindex names

@attack68 attack68 marked this pull request as ready for review July 31, 2021 15:17
@attack68 attack68 changed the title [WIP] BUG: Styler.set_sticky fix the names rows 2/2 BUG: Styler.set_sticky fix the names rows 2/2 Jul 31, 2021
@simonjayhawkins simonjayhawkins added this to the 1.3.2 milestone Aug 3, 2021
@simonjayhawkins simonjayhawkins added the Styler conditional formatting using DataFrame.style label Aug 3, 2021
pandas/io/formats/style.py Show resolved Hide resolved
@jreback
Copy link
Contributor

jreback commented Aug 5, 2021

can you rebase this just to make sure

@jreback jreback merged commit 9774008 into pandas-dev:master Aug 7, 2021
@jreback
Copy link
Contributor

jreback commented Aug 7, 2021

@meeseeksdev backport 1.3.x

@lumberbot-app
Copy link

lumberbot-app bot commented Aug 7, 2021

Something went wrong ... Please have a look at my logs.

jreback pushed a commit that referenced this pull request Aug 8, 2021
…42928)

Co-authored-by: attack68 <24256554+attack68@users.noreply.github.com>
@attack68 attack68 deleted the styler_set_sticky_multi_fix branch August 8, 2021 12:38
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
@ShawnZhong ShawnZhong mentioned this pull request May 21, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Styler conditional formatting using DataFrame.style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Styler.set_sticky(axis="columns") does not work properly with Multi-Index Rows
3 participants