Raise if None is passed for skipna #44579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Nov 23, 2021
doc/source/whatsnew/v1.4.0.rst
Outdated
| @@ -399,6 +399,7 @@ Other API changes | |||
| ^^^^^^^^^^^^^^^^^ | |||
| - :meth:`Index.get_indexer_for` no longer accepts keyword arguments (other than 'target'); in the past these would be silently ignored if the index was not unique (:issue:`42310`) | |||
| - Change in the position of the ``min_rows`` argument in :meth:`DataFrame.to_string` due to change in the docstring (:issue:`44304`) | |||
| - Reduction operations for :class:`DataFrame` or :class:`Series` nor raising a ``ValueError`` when ``None`` is passed for ``skipna`` (:issue:`44178`) | |||
There was a problem hiding this comment.
is this an actual change though? this is just restoring the 1.3.x behavior right?
There was a problem hiding this comment.
In 1.3.x skipna=None was the default, but it was documented as bool, default True. The None was translated into True internally. This was changed to skipna=True in #43980, but now None was evaluated to False internally. This ensures that we raise for non boolean inputs.
jreback
approved these changes
Nov 24, 2021
|
thanks @phofl |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will deprecate mad in follow up