DEPR: datetimelike.astype(int_other_than_i8) return requested dtype #45574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
force-pushed
the
depr-astype-dtlike-inty
branch
from
ee838aa
to
7b41898
Compare
|
dont' we have an issue about this? e.g. can you add the xref to the top |
pandas/core/arrays/datetimelike.py
Outdated
| warnings.warn( | ||
| f"The behavior of .astype from {self.dtype} to {dtype} is " | ||
| "deprecated. In a future version, this astype will " | ||
| "raise if the conversion overflows.", |
There was a problem hiding this comment.
I would make this "if the conversion overflow" a bit clearer in that it does actually happen with the current values (so it's not a hypothetical "if")
There was a problem hiding this comment.
How about "[...] raise if the conversion overflows, as it did in this case with negative int64 values."?
mroeschke
approved these changes
Feb 14, 2022
jorisvandenbossche
approved these changes
Feb 14, 2022
|
Thanks! |
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Feb 14, 2022
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #45034 this should be just non-controversial parts of that discussion cc @jorisvandenbossche