BUG: is_bool_dtype raises AttributeError when checking categorical Series #45616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Robbie-Palmer
commented
Jan 25, 2022
Robbie-Palmer
commented
- closes BUG: is_bool_dtype 'Series' object has no attribute 'categories' #45615
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
added 3 commits
January 25, 2022 12:34
Categories are taken from dtype.categories instead of trying to get them from series.categories
3 tasks
phofl
approved these changes
Jan 28, 2022
jbrockmendel
approved these changes
Jan 28, 2022
|
Could you merge master? |
jreback
reviewed
Jan 30, 2022
doc/source/whatsnew/v1.4.1.rst
Outdated
| @@ -24,7 +24,7 @@ Fixed regressions | |||
| Bug fixes | |||
| ~~~~~~~~~ | |||
| - Fixed segfault in :meth:``DataFrame.to_json`` when dumping tz-aware datetimes in Python 3.10 (:issue:`42130`) | |||
| - | |||
| - Bug in :meth:`api.types.is_bool_dtype` was raising an AttributeError when evaluating a categorical Series (:issue:`45615`) | |||
There was a problem hiding this comment.
normally we would use backticks around AttributeError and Series (as it highlites them). if you can update and ping on green.
There was a problem hiding this comment.
Any advice on how to handle the failing checks?
|
also pls merge master |
…e-support-categorical-series # Conflicts: # doc/source/whatsnew/v1.4.1.rst
|
thanks @Robbie-Palmer |
|
@meeseeksdev backport 1.4.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 31, 2022
…r when checking categorical Series
|
Something went wrong ... Please have a look at my logs. |
Robbie-Palmer
deleted the
45615-is-bool-dtyppe-support-categorical-series
branch
jreback
pushed a commit
that referenced
this pull request
Jan 31, 2022
…cking categorical Series (#45738) Co-authored-by: Robbie Palmer <8760191+Robbie-Palmer@users.noreply.github.com>
simonjayhawkins
added a commit
to simonjayhawkins/pandas
that referenced
this pull request
Feb 8, 2022
…ression section
simonjayhawkins
added
Regression
simonjayhawkins
added a commit
that referenced
this pull request
Feb 8, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Feb 8, 2022
…elease note from bugfix to regression section
simonjayhawkins
added a commit
that referenced
this pull request
Feb 8, 2022
…fix to regression section (#45882) Co-authored-by: Simon Hawkins <simonjayhawkins@gmail.com>
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Feb 14, 2022
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Feb 14, 2022
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.