Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: is_bool_dtype raises AttributeError when checking categorical Series #45616

Merged
merged 6 commits into from
Jan 31, 2022
Merged

BUG: is_bool_dtype raises AttributeError when checking categorical Series #45616

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2827637
Add categorical Series to test_is_bool_dtype
Jan 25, 2022
d96c7ca
Fix is_bool_dtype to work with categorical Series
Jan 25, 2022
c83c22f
Add record of bugfix to v1.4.1 release notes
Jan 25, 2022
044ed4d
Add test case using boolean categorical Series for is_bool_dtype
Jan 28, 2022
dcf2b46
Correct function reference in whatsnew docs
Jan 28, 2022
a93e880
Merge remote-tracking branch 'upstream/main' into 45615-is-bool-dtypp…
Jan 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v1.4.1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Fixed regressions
Bug fixes
~~~~~~~~~
- Fixed segfault in :meth:``DataFrame.to_json`` when dumping tz-aware datetimes in Python 3.10 (:issue:`42130`)
-
- Bug in :meth:`api.types.is_bool_dtype` was raising an AttributeError when evaluating a categorical Series (:issue:`45615`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normally we would use backticks around AttributeError and Series (as it highlites them). if you can update and ping on green.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any advice on how to handle the failing checks?


.. ---------------------------------------------------------------------------

Expand Down
2 changes: 1 addition & 1 deletion pandas/core/dtypes/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1319,7 +1319,7 @@ def is_bool_dtype(arr_or_dtype) -> bool:
return False

if isinstance(dtype, CategoricalDtype):
arr_or_dtype = arr_or_dtype.categories
arr_or_dtype = dtype.categories
# now we use the special definition for Index

if isinstance(arr_or_dtype, ABCIndex):
Expand Down
2 changes: 2 additions & 0 deletions pandas/tests/dtypes/test_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,12 +562,14 @@ def test_is_bool_dtype():
assert not com.is_bool_dtype(int)
assert not com.is_bool_dtype(str)
assert not com.is_bool_dtype(pd.Series([1, 2]))
assert not com.is_bool_dtype(pd.Series(["a", "b"], dtype="category"))
Robbie-Palmer marked this conversation as resolved.
Show resolved Hide resolved
assert not com.is_bool_dtype(np.array(["a", "b"]))
assert not com.is_bool_dtype(pd.Index(["a", "b"]))
assert not com.is_bool_dtype("Int64")

assert com.is_bool_dtype(bool)
assert com.is_bool_dtype(np.bool_)
assert com.is_bool_dtype(pd.Series([True, False], dtype="category"))
assert com.is_bool_dtype(np.array([True, False]))
assert com.is_bool_dtype(pd.Index([True, False]))

Expand Down