REGR: Bar plot axis timestamp to string conversion error #46413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
the
Testing
mroeschke
reviewed
Mar 18, 2022
pandas/tests/plotting/test_misc.py
Outdated
| # GH 38736 | ||
| # Ensure string x-axis from the second plot will not be converted to datetime | ||
| # due to axis data from first plot | ||
| DataFrame( |
There was a problem hiding this comment.
Could you add some sort of assertion to these calls instead of just being a smoke test?
There was a problem hiding this comment.
Added the _check_plot_works function to each plot.
I also want to assert the datatype of the axis of the plots (ie. datetime and string), but I am a bit lost on how I can achieve that.
mroeschke
approved these changes
Mar 20, 2022
|
Thanks @ivan-ngchakming |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
…46413) * test: bar plot axis conversion regr test * test: added check plot works assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added regression test to prevent bar plot from attempting to convert x-axis from string to timestamp due to previous plot's axis units.
Problematic example:
pandas/pandas/plotting/_matplotlib/core.py
Line 1433 in fb35344
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.