Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: deprecate Index.is_integer #50178

Merged
merged 2 commits into from
Jan 13, 2023
Merged

DEPR: deprecate Index.is_integer #50178

merged 2 commits into from
Jan 13, 2023

Conversation

topper-123
Copy link
Contributor

@topper-123 topper-123 mentioned this pull request Dec 10, 2022
Closed
10 tasks
@phofl
Copy link
Member

phofl commented Dec 11, 2022

Have to hold off here a bit, we want to get all deprecations enforced before adding new ones

@topper-123 topper-123 mentioned this pull request Dec 12, 2022
Merged
5 tasks
@mroeschke mroeschke added the Deprecate Functionality to remove in pandas label Dec 12, 2022
@topper-123 topper-123 added the Index Related to the Index class or subclasses label Dec 13, 2022
@topper-123 topper-123 added this to the 2.0 milestone Dec 13, 2022
@datapythonista datapythonista mentioned this pull request Jan 5, 2023
Open
@phofl
Copy link
Member

phofl commented Jan 12, 2023

needs a rebase, can merge afterwards

Terji Petersen and others added 2 commits January 12, 2023 23:55
@topper-123
DEPR: deprecate Index.is_integer
9b6b2fc
@topper-123 @simonjayhawkins
Update pandas/core/indexes/base.py
9606b8e 
Co-authored-by: Simon Hawkins <simonjayhawkins@gmail.com>
@topper-123
Copy link
Contributor Author

Thanks. I’ve rebased.

@phofl phofl merged commit 627bc40 into pandas-dev:main Jan 13, 2023
@phofl
Copy link
Member

phofl commented Jan 13, 2023

thx @topper-123

@topper-123 topper-123 deleted the deprecate_Index.is_integer branch January 13, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins left review comments

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Index Related to the Index class or subclasses
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@topper-123 @phofl @simonjayhawkins @mroeschke