BUG: DatetimeIndex with non-nano values and freq='D' throws ValueError #50773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
added
the
Non-Nano
5 tasks
pandas/core/arrays/datetimes.py
Outdated
| @@ -357,7 +357,7 @@ def _from_sequence_not_strict( | |||
|
|
|||
| if inferred_freq is None and freq is not None: | |||
| # this condition precludes `freq_infer` | |||
| cls._validate_frequency(result, freq, ambiguous=ambiguous) | |||
| cls._validate_frequency(result, freq, ambiguous=ambiguous, unit=result.unit) | |||
There was a problem hiding this comment.
i have a branch where i added unit=index.unit inside _validate_frequency. any reason to that here instead of there?
There was a problem hiding this comment.
sorry which branch?
There was a problem hiding this comment.
yeah that works too
|
thanks @MarcoGorelli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.