-
-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: bfill for interval indexing added GH#51503 #51503 #52103
Conversation
hamedgibago
commented
Mar 21, 2023
•
edited
Loading
edited
- closes NotImplementedError: method backfill not yet implemented for IntervalIndex #51503
- Tests added and passed if fixing a bug or adding a new feature
- All code checks passed.
Some bugs removed
Test is done for |
pandas/core/indexes/interval.py
Outdated
# GH#51503 | ||
if method in ("bfill", "backfill"): | ||
temp = [] | ||
for i in range(len(self)): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These for loops are not going to be performant enough for this feature
Thanks for your pull request @hamedgibago. I noticed this is your first pull request into pandas, so I would recommend first tackling an issue labeled |
I'll do |
I am dubious that that for looping solution over each element will be performant enough for this feature |
I've added this for type of date time check. Let me see if |
Thanks for this pull request, but it appears there hasn't been much traction on this PR in a while so closing for how. Happy for you to tackle an issue that has been triaged or a |