Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: Deprecate empty bool indexer for Index #56055

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Nov 19, 2023

@phofl phofl added the Deprecate Functionality to remove in pandas label Nov 19, 2023
@phofl phofl added this to the 2.2 milestone Nov 19, 2023
@jorisvandenbossche jorisvandenbossche changed the title DEP: Deprecate empty bool indexer for Index DEPR: Deprecate empty bool indexer for Index Nov 20, 2023
@jorisvandenbossche
Copy link
Member

(small side note: can you use "DEPR" instead of "DEP", that's what is most often used I think, and also has less possible confusing with "dependencies")

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jorisvandenbossche jorisvandenbossche added the Indexing Related to indexing on series/frames, not to indexes themselves label Nov 20, 2023
@mroeschke mroeschke merged commit caab88b into pandas-dev:main Nov 20, 2023
44 checks passed
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the dep_bool_0_indexer branch November 20, 2023 21:29
phofl added a commit to phofl/pandas that referenced this pull request Nov 21, 2023
* DEP: Deprecate empty bool indexer for Index

* Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: inconsistency in Index.__getitem__ for Numpy and non-numpy dtypes
3 participants