-
-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: raise ValueError if invalid period freq pass to asfreq when the index of df is a PeriodIndex #56945
Merged
MarcoGorelli
merged 13 commits into
pandas-dev:main
from
natmokval:enh-error-msg-asfreq-invalid-period-freq
Feb 7, 2024
Merged
ENH: raise ValueError if invalid period freq pass to asfreq when the index of df is a PeriodIndex #56945
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
39f59c4
raise ValueError in asfreq for invalid period freq
natmokval 2b602bd
Merge branch 'main' into enh-error-msg-asfreq-invalid-period-freq
natmokval ff1c6e7
correct PeriodIndex.asfreq, fix test, add tests
natmokval fff7c9d
move raising ValueError to to_offset
natmokval a389d11
fix pre-commit errors
natmokval d2ea914
correct def to_offset, dt64arr_to_periodarr and fix tests
natmokval 3735e23
fix tests
natmokval b1e6ba6
correct def to_offset, fix tests
natmokval c41557a
add a note to v2.2.1.rst
natmokval 17fd84c
resolve conflict
natmokval 721637b
Merge remote-tracking branch 'upstream/main' into enh-error-msg-asfre…
MarcoGorelli deea30d
try simplifying / clarifying
MarcoGorelli 4cbcc5e
revert _get_period_alias simplification
MarcoGorelli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few lines down, there's
obj.index.asfreq(freq, how=how)
- should these validation go in there?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, you are right. I moved the check
if isinstance(freq, str)
to the definition ofasfreq
inpandas/core/indexes/period.py