CLN: use isnan() instead of the Py_IS_NAN macro #58850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 3.11 the later is just an alias for isnan(). See also python/cpython#119613
|
What about Python 3.10? Noted on the C99 requirement (we actually require a C11 compiler anyway) but are these macros equivalent still on 3.10 or is there a possibility of a behavior difference? |
|
There is. If you support platforms without IEEE 754, without NaN, and without C99+ |
|
OK thanks for that info. I think we are OK with this as is then. Appreciate the PR |
WillAyd
approved these changes
May 28, 2024
|
Thanks @skirpichev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 3.11 the later is just an alias for isnan(). See also python/cpython#119613