BUG: fix for GH9010

[PollyP]

Superseded by #9358

---

This is an update of PR #9024.

closes #9010

[shoyer]

I still think this should just be underlying_price.replace(',', ''). As noted in the other PR, this method is not deprecated in Python 3: https://docs.python.org/3/library/stdtypes.html#str.replace

[jreback]

@PollyP can you rebase, and update according to comments by @shoyer

[PollyP]

OK, will do by Saturday at the latest.

On Sun, Jan 18, 2015 at 1:00 PM, jreback notifications@github.com wrote:

@PollyP https://github.com/PollyP can you rebase, and update according
to comments by @shoyer https://github.com/shoyer

—
Reply to this email directly or view it on GitHub
#9198 (comment).

[PollyP]

Looks like dstephens99 went ahead and fixed this.

[jorisvandenbossche]

yes, @dstephens99 fixed it in pandas-datareader, but until we decide what exactly to do with the code in pandas, this can maybe still be merged in pandas? (@jreback)

(only reopened to be sure we decide on this, we can just close it again if we are not going to merge this)

[jreback]

see comments here: pydata/pandas-datareader#15

[jreback]

@jorisvandenbossche are we merging this?

[jorisvandenbossche]

I think we should close this in favor of #9358 (which brings the changes made in pandas-datareader to back to pandas, including this)

@PollyP Thanks for your work on this! If you want to do more fixes in the future, you can submit them directly to pandas-datareader.