BUG:Fix options strike price float conversions if comma. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidastephens
force-pushed
the
issue7
branch
from
0832a99
to
59f09cc
Compare
davidastephens
added a commit
that referenced
this pull request
Jan 23, 2015
BUG:Fix options strike price float conversions if comma.
| # check for comma | ||
| underlying_price = underlying_price.replace(',', '') | ||
|
|
||
| try: |
There was a problem hiding this comment.
Note: You could probably indent this block so float is only applied once is the usual case, or always replace (which may be cleaner).
|
@hayd Yes, I prefer the always replace for cleanliness. I don't think the performance penalty would be that bad, given that this doesn't get called that often (once per underlying). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7
Based on PR: pandas-dev/pandas#9198