Improve hosted nREPL for CIDER users. #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same middleware and dependencies that would be loaded for the Boot `repl` task are also used for the nREPL hosted by the HTTP server. This includes the middleware configured in a user's `boot.profile` (assuming that they've followed the standard recipe of concating additional dependencies to `boot.repl/*default-dependencies*`; cf. https://github.com/boot-clj/boot/wiki/Cider-REPL#a-better-way) It is particularly useful for CIDER users, who require `cider-nrepl` and associated middleware to be loaded into the nREPL server for CIDER to be fully functional.
This file enables port tab completion for CIDER users.
sinistral
added a commit
to sinistral/csm-adapt.sagittariidae-ws
that referenced
this pull request
Sep 28, 2016
* tweak Project and JAR file name * improved dependency declaration * tweak source directory location * tweak primary namespace path * trivial compojure route to test boot-http CIDER nREPL support (depends on pandeiro/boot-http#52)
|
Thanks, this is a great change! Re: testing, it would really require some thought. Test coverage really needs to be revamped or even rethought for this and other recent features. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to make the hosted nREPL more useful to CIDER users by loading user-specific middleware and enabling connection tab completion. Most of this has been shamelessly lifted from Boot's own
repltask.Any feedback is welcome, including thoughts on how to test this.