Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated _flat warning #1

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Remove deprecated _flat warning #1

merged 1 commit into from
Oct 4, 2022

Conversation

michaelfarrelly
Copy link

@michaelfarrelly michaelfarrelly commented Oct 3, 2022 •
edited by milang
Loading

Follow-up PR after #2.

When using leaflet-draw package, console warnings would appear with Deprecated use of _flat, please use L.LineUtil.isFlat instead.

@michaelfarrelly michaelfarrelly self-assigned this Oct 3, 2022
@milang milang changed the base branch from pandell-master to cleanup-repo October 4, 2022 01:13
milang
milang approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@milang milang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that I rebased and amended this PR to only keep changes related to the _flat warning fix. All infrastructure- and repository-related changes were migrated to #2.

101100
101100 approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@101100 101100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 🍪

Base automatically changed from cleanup-repo to pandell-master October 4, 2022 18:19
@michaelfarrelly michaelfarrelly merged commit 1f5bad3 into pandell-master Oct 4, 2022
@michaelfarrelly michaelfarrelly deleted the deprecated-fix branch October 4, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milang milang milang approved these changes

@101100 101100 101100 approved these changes

Assignees

@michaelfarrelly michaelfarrelly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelfarrelly @milang @101100