Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test basic document conversions #21

Merged
merged 5 commits into from
Mar 5, 2019
Merged

Conversation

tarleb
Copy link
Member

@tarleb tarleb commented Mar 1, 2019

No description provided.

@tarleb
Copy link
Member Author

tarleb commented Mar 1, 2019

Slightly improved version of #19; new PR for CI testing.

@svenevs
Copy link
Member

svenevs commented Mar 4, 2019

This is awesome. I'm pretty sure I can do what I just did with the circle ci config to parameterize things, we'll see what the build does.

  • good enough xD The IMAGE= target specific variable stuff. Is there an easier way to do that more generally without defining a template function? It's really useful for me right now for example testing the other latex image PR, which I have tagged as something else locally.

    • If there's no cleaner way, I personally think copy-pasta here is ok ... we aren't going to have that many image stacks right? (we should be relatively selective ...)
  • In the core tests there's this thing

    $ docker run --rm -it -v /home/circleci/project/test:/data pandoc/core:edge example.native --output=/dev/null --to=html
    [WARNING] Could not convert TeX math '\frac{d}{dx}f(x)=\lim_{h\to 0}\frac{f(x+h)-f(x)}{h}', rendering as TeX

    Is this testing something specific? This prevents a --fail-if-warnings on the core tests.

  • [WARNING] Missing character: There is no ∈ in font [lmroman10-regular]:mapping=tex-text;!

    This fails CI. I don't understand this test...This comes from the latex tests, but it doesn't actually fail, it seems like it's from the \in command in creating example.native => exmaple.pdf. Since pandoc doesn't fail even though we are doing --fail-if-warnings, and a seems to show up fine, I'm inclined to think this is OK. Just trying to figure out if we need to fix a font issue or not.

Other than these three minor things, I think this is more than complete -- this is stupidly useful for #14 💥

This was referenced Mar 4, 2019
@svenevs
Copy link
Member

svenevs commented Mar 4, 2019

update: There is no ∈ in font is a problem. I will take closer look tomorrow, I don't really understand this test. I don't know why it didn't fail locally, but I think it's good that it fails on CI.

@tarleb
Copy link
Member Author

tarleb commented Mar 4, 2019

There was a bug that prevented pandoc to error-out in some situations (jgm/pandoc#5343, also jgm/pandoc#4455). This has been fixed now, which is why the tests fail now. I'll take a look.

@tarleb
Copy link
Member Author

tarleb commented Mar 4, 2019

Also: hurray for CI tests 🎉 😄

The file was taken from pandoc's test directory; it should retain its
original name.
Any other math rendering method would work, as long as it can render
fractions.
@svenevs svenevs merged commit 84cf431 into pandoc:master Mar 5, 2019
@svenevs
Copy link
Member

svenevs commented Mar 5, 2019

this is just wonderful! thanks for doing this @tarleb ❤️

@tarleb tarleb deleted the smoke-tests branch March 5, 2019 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants