Differences from server

[coil0]

• Missing nil check for item stack in on_rightclick for anvil
• atm is missing the nil check in atm.patch
• Different recipe for banners:steel_pole
• Different recipe for castle_weapons:crossbow_bolt
• ccompass is missing throttling and a fix for conflicting recipe with digtron
• Recipe for charcoal uses group:tree instead of group:wood
• Income is enabled in the currency mod (it's commented on the server); however, income is configurable upstream now so there's no need to create a fork
• fancy_vend has mail enabled (and probably not working)
• loot has a lower interval (1 instead of 2) for the loot:loot_node ABM (non-isue: i think i was just experimenting there)
• mobs_animal is missing change on server for breeding penguin
• moreblocks is missing changes in moreblocks.patch
• pandorabox_custom is missing changes in pandorabox_custom.patch
• In prefab, electric fence damage is 30 instead of 2
• replacer is missing patch for placing in vacuum
• smartrenting is missing change to comment override_items.lua
• spawn_command is missing changes in spawn_command.patch (embedded dep: pandorabox-io/pandorabox_custom@002460c)
• stamina is missing a few commits
• unified_inventory_plus is missing changes in unified_inventory_plus.patch
• vines is missing changes in vines.patch (non-issue: nodetimers were not the problem)
• woodcutting is missing changes in woodcutting.patch
• xp_redo is missing changes to comment xp loss on death
• biomelib is disabled on the current server
• This repo has more recent commits for fancy_vend, farming_nextgen, homedecor_modpack, ilights, jumpdrive, led_marquee, mail, mesecons_stealthnode, missions, moretrees, planetoidgen, signs_lib, spacecannon, tpr, wine

[thomasrudin]

Oh my, that stuff accumulated over time :/
I'll comment on this when i'm doing work on that...

Another thing: I separated the mt_auth repo into app and mod (b618d3e), is it ok if we move the submodules to the root path?

[coil0]

Yes, but then we’d have all of plantlife_modpack. The symlink picks out just plantlife_i18n. Otherwise, it’d be nice to get rid of the symlinks since world.mt can already be used to enable and disable mods.

[thomasrudin]

I removed the smartrenting mod completely, this thing was buggy to begin with and to no real use.

[coil0]

Missing nil check for item stack in on_rightclick for anvil

Seems impossible for itemstack to be nil unless a mod calls minetest.item_place with nil. Even then, it would still crash a few lines later if there was no placer because builtin also assumes itemstack is not nil.

xp_redo is missing changes to comment xp loss on death

Can be replaced by mt-mods/xp_redo#33.

[thomasrudin]

Missing nil check for item stack in on_rightclick for anvil

Seems impossible for itemstack to be nil unless a mod calls minetest.item_place with nil. Even then, it would still crash a few lines later if there was no placer because builtin also assumes itemstack is not nil.

Oh, that was the "anvil of doom" issue: the travelnet tries to do a rightclick on nearby nodes: https://github.com/Sokomine/travelnet/blob/master/init.lua#L654

xp_redo is missing changes to comment xp loss on death

Can be replaced by thomasrudin-mt/xp_redo#33.

Thx, merged :)

I'll test the new meta-repo on the test-server (test.pandorabox.io) but can we merge #2 before that?

[coil0]

Oh, that was the "anvil of doom" issue: the travelnet tries to do a rightclick on nearby nodes: https://github.com/Sokomine/travelnet/blob/master/init.lua#L654

Submitted a fix (to anvil, even though it's really travelnet that needs fixed).

I'll test the new meta-repo on the test-server (test.pandorabox.io) but can we merge #2 before that?

Yes, I merged #4.

[thomasrudin]

I switched the protector mod to tenplus1's original one again, my only local modification was some warning if the globalstep took too long

[thomasrudin]

woodcutting upstream issue: minetest-mods/woodcutting#4

[thomasrudin]

prefab setting: minetest-mods/prefab#4

[thomasrudin]

Unified inventory settings: mt-mods/unified_inventory_plus#2

[thomasrudin]

@coil0 about the replacer commits: should we switch to your branch or do you want to wait for the PR to be merged?

EDIT: my preference would be to switch to forks until the PR's are merged...

[coil0]

#10 switches to my branch. If the upstream PR does not get merged, we could switch to HybridDog's fork, which has other improvements for creative and doesn't break metadata.

[thomasrudin]

closing due to installement of the repo, thx for the help @coil0 👍