Mesecons/punch/digtron/pipeworks crash

[BobFred7]

2020-02-16 01:25:44: ERROR[Main]: ServerError: AsyncErr: environment_Step: Runtime error from mod '' in callback environment_Step(): /data/world//worldmods/digtron/util.lua:361: bad argument #1 to 'punch' (userdata expected, got table)
2020-02-16 01:25:44: ERROR[Main]: stack traceback:
2020-02-16 01:25:44: ERROR[Main]: 	[C]: in function 'punch'
2020-02-16 01:25:44: ERROR[Main]: 	/data/world//worldmods/digtron/util.lua:361: in function 'damage_creatures'
2020-02-16 01:25:44: ERROR[Main]: 	/data/world//worldmods/digtron/nodes/node_diggers.lua:151: in function 'damage_creatures'
2020-02-16 01:25:44: ERROR[Main]: 	/data/world//worldmods/digtron/util_execute_cycle.lua:299: in function 'f'
2020-02-16 01:25:44: ERROR[Main]: 	.../worldmods/monitoring/monitoring/metrictypes/counter.lua:45: in function 'execute_dig_cycle'
2020-02-16 01:25:44: ERROR[Main]: 	/data/world//worldmods/digtron/nodes/node_controllers.lua:60: in function 'on_rightclick'
2020-02-16 01:25:44: ERROR[Main]: 	/usr/local/share/minetest/builtin/game/item.lua:417: in function 'on_place'
2020-02-16 01:25:44: ERROR[Main]: 	/data/world//worldmods/pipeworks/wielder.lua:424: in function 'act'
2020-02-16 01:25:44: ERROR[Main]: 	/data/world//worldmods/pipeworks/wielder.lua:114: in function 'wielder_on'
2020-02-16 01:25:44: ERROR[Main]: 	/data/world//worldmods/pipeworks/wielder.lua:150: in function 'f'
2020-02-16 01:25:44: ERROR[Main]: 	.../worldmods/monitoring/monitoring/metrictypes/counter.lua:45: in function 'old_action_on'
2020-02-16 01:25:44: ERROR[Main]: 	/data/world//worldmods/mesecons_ratelimiter/api.lua:36: in function 'action_on'
2020-02-16 01:25:44: ERROR[Main]: 	/data/world//worldmods/mesecons/mesecons/internal.lua:190: in function </data/world//worldmods/mesecons/mesecons/internal.lua:183>
2020-02-16 01:25:44: ERROR[Main]: 	/data/world//worldmods/mesecons/mesecons/actionqueue.lua:137: in function 'old_execute'
2020-02-16 01:25:44: ERROR[Main]: 	/data/world//worldmods/mesecons_debug/overrides.lua:48: in function 'f'
2020-02-16 01:25:44: ERROR[Main]: 	.../worldmods/monitoring/monitoring/metrictypes/counter.lua:45: in function 'execute'
2020-02-16 01:25:44: ERROR[Main]: 	/data/world//worldmods/mesecons/mesecons/actionqueue.lua:111: in function </data/world//worldmods/mesecons/mesecons/actionqueue.lua:73>
2020-02-16 01:25:44: ERROR[Main]: 	/usr/local/share/minetest/builtin/game/register.lua:429: in function </usr/local/share/minetest/builtin/game/register.lua:413>
2020-02-16 01:25:44: ERROR[Main]: stack traceback:

[BobFred7]

Similar error occurred again:

2020-02-16 01:29:31: ERROR[Main]: ServerError: AsyncErr: environment_Step: Runtime error from mod '' in callback environment_Step(): /data/world//worldmods/digtron/util.lua:361: bad argument #1 to 'punch' (userdata expected, got table)
2020-02-16 01:29:31: ERROR[Main]: stack traceback:
2020-02-16 01:29:31: ERROR[Main]: 	[C]: in function 'punch'
2020-02-16 01:29:31: ERROR[Main]: 	/data/world//worldmods/digtron/util.lua:361: in function 'damage_creatures'
2020-02-16 01:29:31: ERROR[Main]: 	/data/world//worldmods/digtron/nodes/node_diggers.lua:151: in function 'damage_creatures'
2020-02-16 01:29:31: ERROR[Main]: 	/data/world//worldmods/digtron/util_execute_cycle.lua:299: in function 'f'
2020-02-16 01:29:31: ERROR[Main]: 	.../worldmods/monitoring/monitoring/metrictypes/counter.lua:45: in function 'execute_dig_cycle'
2020-02-16 01:29:31: ERROR[Main]: 	/data/world//worldmods/digtron/nodes/node_controllers.lua:60: in function 'on_rightclick'
2020-02-16 01:29:31: ERROR[Main]: 	/usr/local/share/minetest/builtin/game/item.lua:417: in function 'on_place'
2020-02-16 01:29:31: ERROR[Main]: 	/data/world//worldmods/pipeworks/wielder.lua:424: in function 'act'
2020-02-16 01:29:31: ERROR[Main]: 	/data/world//worldmods/pipeworks/wielder.lua:114: in function 'wielder_on'
2020-02-16 01:29:31: ERROR[Main]: 	/data/world//worldmods/pipeworks/wielder.lua:150: in function 'f'
2020-02-16 01:29:31: ERROR[Main]: 	.../worldmods/monitoring/monitoring/metrictypes/counter.lua:45: in function 'old_action_on'
2020-02-16 01:29:31: ERROR[Main]: 	/data/world//worldmods/mesecons_ratelimiter/api.lua:36: in function 'action_on'
2020-02-16 01:29:31: ERROR[Main]: 	/data/world//worldmods/mesecons/mesecons/internal.lua:190: in function </data/world//worldmods/mesecons/mesecons/internal.lua:183>
2020-02-16 01:29:31: ERROR[Main]: 	/data/world//worldmods/mesecons/mesecons/actionqueue.lua:137: in function 'old_execute'
2020-02-16 01:29:31: ERROR[Main]: 	/data/world//worldmods/mesecons_debug/overrides.lua:48: in function 'f'
2020-02-16 01:29:31: ERROR[Main]: 	.../worldmods/monitoring/monitoring/metrictypes/counter.lua:45: in function 'execute'
2020-02-16 01:29:31: ERROR[Main]: 	/data/world//worldmods/mesecons/mesecons/actionqueue.lua:111: in function </data/world//worldmods/mesecons/mesecons/actionqueue.lua:73>
2020-02-16 01:29:31: ERROR[Main]: 	/usr/local/share/minetest/builtin/game/register.lua:429: in function </usr/local/share/minetest/builtin/game/register.lua:413>
2020-02-16 01:29:31: ERROR[Main]: stack traceback:

[S-S-X]

I'll take a closer look at this tomorrow and test a bit if I can reproduce this on local server. That's digitron crashing again...

[S-S-X]

Proper fix would probably go somewhere in pipeworks but it wont hurt to have check in digtron so I'll add simple check there for now.

[S-S-X]

auto close because of "fix" in commit msg... let this wait for PR and revert remote to https://github.com/minetest-mods/digtron.git

[thomasrudin]

Judging from the backtrace this looks like a mesecons triggered pipeworks-deployer that again triggers a digtron-controller... 😲

https://gitlab.com/VanessaE/pipeworks/-/blob/master/wielder.lua#L424

I don't think that was the idea behind the deployers but it should not crash either... :/

@S-S-X there was a missing branch attribute in the .gitmodules file: pandorabox-io/pandorabox-mods@6c64a34

[S-S-X]

Judging from the backtrace this looks like a mesecons triggered pipeworks-deployer that again triggers a digtron-controller...

Yes, I tested that old machine again as it seemed to work but didn't realize first that I caused crash by walking in front of dig heads and those attempted punch which failed in core because invalid value (fake player data table) was given instead of real player object.

I don't think that was the idea behind the deployers

But... that's idea behind minetest to test how things work 😁

there was a missing branch attribute in the .gitmodules

AFAIK submodules do not normally track anything but instead fetch commit as detached head.

[BuckarooBanzay]

thanks @S-S-X 👍