Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is odgi overlap optimized for reciprocal overlaps? #502

Open
cgroza opened this issue May 22, 2023 · 2 comments
Open

Is odgi overlap optimized for reciprocal overlaps? #502

cgroza opened this issue May 22, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@cgroza
Copy link

cgroza commented May 22, 2023

Hi,

Currently comparing a large number of paths in a pangenome graph.
If odgi overlap knows that A overlaps B, will it skip checking if B overlaps A?
I looked at the source code and from what I gather it seems like it will but I could be wrong.

Just looks like a quick optimization that could save a lot of time when comparing large number of paths.

@cgroza cgroza changed the title Is odgi paths optimized for reciprocal overlaps? Is odgi overlap optimized for reciprocal overlaps? May 22, 2023
@AndreaGuarracino
Copy link
Member

Hi @cgroza, odgi overlap does not keep this kind of memory, so there is no such optimization. It would be achievable by increasing the memory usage while keeping all already detected pairs in memory.

@AndreaGuarracino AndreaGuarracino added the enhancement New feature or request label Jun 14, 2023
@cgroza
Copy link
Author

cgroza commented Jun 14, 2023

I see, maybe there could be a memory efficient way to store this in memory (like a pair of integers).
Then, odgi would not output a full matrix, but a sparse one?
This is most useful for comparing large numbers of paths on a pangenome.
I am thinking sets of epigenomic annotations on a pangenome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants