relax dim requirements #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronspring
changed the title
aaronspring
commented
Aug 2, 2020
aaronspring
commented
Aug 2, 2020
Comment on lines
+123
to
+125
| # set default dim # TODO: should we still do this? | ||
| if dim is None: | ||
| dim = 'init' if kind == 'hindcast' else ['init', 'member'] | ||
| # check allowed dims | ||
| if kind == 'hindcast': | ||
| is_in_list(dim, ['member', 'init'], 'dim') | ||
| elif kind == 'PM': | ||
| is_in_list(dim, ['member', 'init', ['init', 'member']], 'dim') | ||
| dim = ['init'] if kind == 'hindcast' else ['init', 'member'] |
There was a problem hiding this comment.
we could also prevent default keywords for comparison in this PR. should we @bradyrx?
There was a problem hiding this comment.
Let's just keep this as is for this PR. We can discuss the requirement of dim for .verify() funcs. I feel like it's very common to expect a reduction over init for users, but makes sense to expect them to know metric, alignment, etc. We can talk more about it
aaronspring
commented
Aug 2, 2020
aaronspring
commented
Aug 2, 2020
aaronspring
commented
Aug 2, 2020
19 tasks
bradyrx
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
he.verify(dim=['lon','lat'])dimany more, when dimdoesntmatch metric/comparison/dataset.dims (breaking change): fix tests relying on thatdimare not present inskill, fore2rande2omemberdoes not need to be provided asdim, but still gets reduced inforecast.mean('member')logical, needed for doppyo PRsCloses #282
Prepares: doppyo integration
Type of change
Please delete options that are not relevant.
asvto detect performance changes)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. This could point to a cell in the updated notebooks. Or a snippet of code with accompanying figures here.
Checklist (while developing)
pytest, if necessary.Pre-Merge Checklist (final steps)
References
Please add any references to manuscripts, textbooks, etc.