-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing image on load page #12
missing image on load page #12
Comments
Yes, we should fix this. I'm not sure why this isn't working. I think this page should be inhereting from the 'page.html' but something does seem to be broken. I'd bet @dsludwig knows what's up here. |
If anyone wants to fix this in the next 10 minutes that would be great. 😜 |
It's due to the url prefix being a relative URL, which evaluates differently on different pages. #16 should fix it. |
Hmmm, this still seems to be a problem. Will look into it more. |
This appears to be now fixed. |
You are right. I was looking at the wrong page |
This is the URL we are looking for. It exists The logo link is rending as
with a relative, rather than absolute, URL. The problem is with these lines: pangeo-binder/deploy/binder_config.yml Lines 13 to 17 in b32b6bc
@minrk added the extra |
@rabernat - I just tried with your attempt -- no joy!. Now the image is coming from: https://staging.binder.pangeo.io/v2/gh/jhamman/dask-examples/extra_static/pangeo_simple_logo.svg So we need to strip out the repo info: https://staging.binder.pangeo.io/extra_static/pangeo_simple_logo.svg |
@jhamman @rabernat I think the problem is in Leading <img id="logo" src={% block logo_image %}"/extra_static/pangeo_simple_logo.svg"{% endblock logo_image %} width="390px" /> pangeo-data/pangeo-custom-binderhub-templates#2 didn't fix the logo in loading page because loading page uses I would also delete |
Thanks @bitnik. That gets us closer. Any idea why the change in pangeo-data/pangeo-custom-binderhub-templates@17bfade would cause the page header css to be stripped out? |
I assume there should be a pangeo logo at the top of this page, no?
The text was updated successfully, but these errors were encountered: