require dask-gateway>0.9 #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Once this is in staging, we can re-run #167 or make a new PR with an empty commit whose message is Assuming that dask-gateway 0.9 is required in the image, we can update default binder and then the pins in all of the galleries (may be a good time to automate this step!) |
That's neat! I wasn't following those changes. I'll merge this since it's less disruptive than the hub changes and we can tackle those second. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goes along with pangeo-data/pangeo-cloud-federation#875
this allows using images with dask-gateway>=0.9 . But this also might mean that images with dask-gateway<0.9 may no longer work?
note that one advantage of this repository not explicitly using the daskhub chart (compared to the jupyterhubs https://github.com/pangeo-data/pangeo-cloud-federation/blob/d7deb23224604150b5380946367d0d95d42e45cb/pangeo-deploy/Chart.yaml#L6-L12) seems to be that we can upgrade dask-gateway without touching any of the jupyterhub pieces!