Have default dask-gateway image match #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mmm, this doesn't quite work. The config is executed on the the server, which doesn't have access to the JUPYTER_IMAGE_SPEC. Will think on this a bit more. The |
TomAugspurger
added a commit
to TomAugspurger/pangeo-cloud-federation
that referenced
this pull request
Jan 24, 2020
Merged
TomAugspurger
added a commit
that referenced
this pull request
Jan 26, 2020
* bump * trigger ci * Nest under dask-gateway? * use pangeo-image * Revert "Merge pull request #506 from TomAugspurger/match-default-image" This reverts commit bd106c8, reversing changes made to 6dd8830. * use local config * trivial change to trigger rebuild * Bump build timeouts * pin versions (ocean) (#514)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the default image for dask-gateway to
JUPYTER_IMAGE_SPEC, which is probably a good default.