-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try pytorch again #367
try pytorch again #367
Conversation
/condalock |
/condalock again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for working on this. LGTM, but I don't fully understand the details.
We actually have two potential silent errors and I am trying to make sure we don't face them here in the containers. Our conda-forge tensorflow build is usually solid, and is designed to take precedence, so we usually run into problems with jaxlib (especially when in the same env as tensorflow) along the lines:
For use, people will likely need a separate dataloader/datapipeline to use with jax anyway, so it makes sense to make jax and tensorflow live together in harmony --- we likely could and should add pytorch to the mix soon! I am not certain about bandwidth/storage limitation but having a super ML container (containing all platforms a la kaggle or colab) may be a good idea, albeit heavy to store and heavy to pull, etc. |
/condalock |
@scottyhq is this stuck now or can you resolve the conflicts without going file by file? Maybe best to open a new PR? (Edit: trying to see if the smart bots --- condalock --- can unlock it!) At any rate, you can safely unpin pytorch like I did here and things should be good to go. I will close this PR this weekend if no further activity (I like to keep open only issues and PRs that are not moot, actually following @rabernat's blog post about using github issues/PRs as a calendar/todo list!) |
/condalock |
/condalock |
Unfortunately the bots are not currently smart enough to resolve lockfiles when one active PR is merged before another. It's really a one PR at a time setup right now, which is fine most of the time :) Thanks again @ngam for all your hard work on the ML library dependencies and packaging |
fixes #358
I will also add a crucial test for jaxlib here, forgot to add it in #364