Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial.ipynb update #122

Merged
merged 2 commits into from Jan 12, 2023
Merged

Tutorial.ipynb update #122

merged 2 commits into from Jan 12, 2023

Conversation

norlandrhagen
Copy link
Contributor

Reran tutorial.ipynb with rechunker version 0.5 to remove copy_chunk_output messages in the documentation.

ex:

_copy_chunk((slice(0, 100, None), slice(0, 25, None), slice(0, 53, None)))
_copy_chunk((slice(100, 200, None), slice(0, 25, None), slice(0, 53, None)))
_copy_chunk((slice(200, 300, None), slice(0, 25, None), slice(0, 53, None)))
etc..```

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rabernat
Copy link
Member

Thanks for this contribution @norlandrhagen and sorry for letting it lie stagnant for so long. I'll try to figure out what's up with the failing tests.

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #122 (9281d4b) into master (46db807) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   96.35%   96.35%           
=======================================
  Files          11       11           
  Lines         548      548           
  Branches      105      100    -5     
=======================================
  Hits          528      528           
  Misses         13       13           
  Partials        7        7           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rabernat
Copy link
Member

I think I can merge this. Sorry for letting it linger so long.

We can ignore the failing test. Beam is broken with python 3.10. (See pangeo-forge/pangeo-forge-recipes#470).

@rabernat rabernat merged commit 1da2476 into pangeo-data:master Jan 12, 2023
@norlandrhagen
Copy link
Contributor Author

No worries at all @rabernat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants