Allow rechunking to groups #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
===========================================
+ Coverage 70.03% 96.12% +26.09%
===========================================
Files 11 11
Lines 554 568 +14
Branches 106 113 +7
===========================================
+ Hits 388 546 +158
+ Misses 149 14 -135
+ Partials 17 8 -9
|
jhamman
reviewed
Aug 11, 2023
rechunker/api.py
Outdated
| @@ -287,6 +289,10 @@ def rechunk( | |||
| * python | |||
| * pywren | |||
|
|
|||
| array_name: str, optional | |||
| Required when rechunking an array if the any of the targets is a group | |||
There was a problem hiding this comment.
Suggested change
| Required when rechunking an array if the any of the targets is a group | |
| Required when rechunking an array if any of the targets are a group |
rechunker/api.py
Outdated
| @@ -142,12 +142,13 @@ def _encode_zarr_attributes(attrs): | |||
|
|
|||
| def _zarr_empty(shape, store_or_group, chunks, dtype, name=None, **kwargs): | |||
| # wrapper that maybe creates the array within a group | |||
| if name is not None: | |||
| assert isinstance(store_or_group, zarr.hierarchy.Group) | |||
| if isinstance(store_or_group, zarr.hierarchy.Group): | |||
There was a problem hiding this comment.
Is there a difference between zarr.hierarchy.Group and zarr.Group? Later on you use the latter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows
target_storeandtemp_storeto be existing Zarr groups rather than store objects.