Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix in prepare_target: catch PathNotFoundError. #394

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

alxmrs
Copy link
Contributor

@alxmrs alxmrs commented Aug 2, 2022

Prepare target checks if a Zarr exists by attempting to open a Zarr and then creating one when an error occurs. I've found that in addition to the zarr.errors.GroupNotFoundError, the zarr.errors.PathNotFoundError needs to be caught in order to not break the xarray_zarr.py pipeline.

Prepare target checks if a Zarr exists by attempting to open a Zarr and then creating one when an error occurs. I've found that in addition to the `zarr.errors.GroupNotFoundError`, the `zarr.errors.PathNotFoundError` needs to be caught in order to not break the xarray_zarr.py pipeline.
@rabernat
Copy link
Contributor

Looks like a prefect release has broken all of our test suite.

ImportError while loading conftest '/home/runner/work/pangeo-forge-recipes/pangeo-forge-recipes/tests/conftest.py'.
tests/conftest.py:29: in <module>
    from prefect.executors import DaskExecutor
E   ModuleNotFoundError: No module named 'prefect.executors'

I think the solution is probably to pin an older version of prefect in our CI. Since we are planning on removing prefect support anyway, I don't see any reason not to do this as a short term fix to get the tests passing.

@rabernat
Copy link
Contributor

Prefect test issue is being fixed in #398. In the meantime, LGTM.

@rabernat rabernat merged commit dfdae4f into pangeo-forge:master Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants