New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dask Gateway example #2
Conversation
Ah cool CI is set up here, and it did fail with I'm happy to help out here, but I'll wait to hear from you. I suspect you've already given some thought to running real examples that access cluster resources. |
All this stuff is configured here: example-gallery/binder-gallery.yaml Lines 1 to 9 in 6cc2c95
The error is work because it's not pointing at the right binder. I would love if you would update your PR to point at the correct binder repo (pangeo-gallery/default-binder). Let's see if we can turn it green. |
Great, binderbot finished. Last commit should get this passing (perhaps a recent update to yamllint requires that files start with
|
All green! (and the binderbot stage finished in <1 minute!) |
I'd love some help brainstorming how to make this workflow better. What just happened is that binderbot built all the notebooks. Now that I merged, it will build them all again on the master branch. In the future, these notebooks might be very expensive, requiring lots of workers and a long run time. I would like to avoid running them more than is necessary. It seems like we should be able to generate an artifact for each notebook tied to a commit hash. If the notebook has not been updated in the current commit, then we can skip building it and instead download it from the artifact. Does anyone have any idea how to make this work? |
Also, it looks like sphinx did not like this notebook because it didn't have a title: https://github.com/pangeo-gallery/pangeo-gallery/runs/546585339?check_suite_focus=true#step:7:31 |
Just to confirm, the second build is done by The results are sitting somewhere in the user directory of the "pull request" binder user. However, that's going to go away somewhat soon after the pull request completes. But... what if I'll fix the example, and try to update the linter to fail CI when there's no title. |
✅
They are actually downloaded to the local run directory for the github worklfow, overwriting the original notebooks. (This is part of binderbot.) I believe this simplifies things considerably |
@rabernat a test / example using dask. Some questions
Gateway
won't generally work outside of a machine that's been configured (likehub.pangeo.io
)If this is likely to cause issues we might want to hold off on merging.