Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the n and p shortcuts #4

Closed
Julow opened this issue Feb 22, 2024 · 3 comments
Closed

Improve the n and p shortcuts #4

Julow opened this issue Feb 22, 2024 · 3 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@Julow
Copy link
Collaborator

Julow commented Feb 22, 2024

The n and p shortcuts currently increment and decrement an integer. This integer is used as the index of the hunk to show on the screen.

This is a bad user experience as the integer can be incremented above the number of hunks, which has no visible effect except that the next n will also have no visible effect.

The p shortcuts should not set a value equal or above the number of hunks.
The n shortcuts should not set a negative value.

@yokurang
Copy link
Collaborator

yokurang commented Mar 4, 2024

Hi, could I please be assigned this task?

Here is a screenshot as required:

image

On another note, after reading the code base, it seems like this issue is closely related to this issue as well: #6

I think it might be more efficient to assign these both to me so my fix to this issue will likely be a fix to the related issue above too.

Cheers,
yokurang

@panglesd
Copy link
Owner

panglesd commented Mar 4, 2024

Let this issue and #6 be assigned to you!

@panglesd
Copy link
Owner

panglesd commented Mar 7, 2024

Fixed by #26 !

@panglesd panglesd closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants