[yokurang] Added a zipper implementation and integrated it into interactive_viewer.ml accompanied with unit tests and an mli file. #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution to issues #4 and #6
Run
and test using
One concern I have is that I am unsure whether my implementation of using the zipper accomplished the task of a more efficient experience for very large diff files. Is there a way for me to check this? I tried manually traversing a large diff file and comparing using my changes and the old changes, but perhaps my diff file wasn't large enough to feel the difference?
Any recommendations or thought would be appreciated. Thank you !
On a further note, I added a helper function for navigating between
Next
andPrev
patches. This navigation has a built in check to ensure that we only navigateNext
orPrev
if there are elements to navigate to. Note the if statements in the code snippet below. This is my solution to issue #4@Julow @panglesd