Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo #533

Merged
merged 1 commit into from Jul 13, 2016
Merged

typo #533

merged 1 commit into from Jul 13, 2016

Conversation

romgrk
Copy link
Contributor

@romgrk romgrk commented Jul 13, 2016

Additionnal thoughts:

  • thought about having NodeJS keywords?
  • Add @Comment group to syntax region jsComment start=/\/\// end=/$/ contains=jsCommentTodo,@Spell extend keepend? That way people can add their own comment-highlighting whitout hacking through the whole syntax.

@amadeus amadeus merged commit 2af5f55 into pangloss:develop Jul 13, 2016
@amadeus
Copy link
Collaborator

amadeus commented Jul 13, 2016

Thanks for submitting the PR, good eye.

Since NodeJS is so common, I am totally ok with adding certain important NodeJS keywords. Other NodeJS related stuff could always be added in a plugin as well.

The @Comment group is not a bad idea, I can certainly look into something like this soon.

If you can perhaps start an issue or a PR with the NodeJS things you'd like to see, that would be a good starting place for that discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants