fix: Only prettify HTML in production (#74)

The prettification is kinda heavy on computing time. To reduce the load during development, this will only be executed in production.
pangolinjs · Dec 15, 2019 · 4e074f9 · 4e074f9
1 parent 1a6c241
commit 4e074f9
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 3 deletions.
diff --git a/lib/webpack/pangolin-loader.js b/lib/webpack/pangolin-loader.js
@@ -98,10 +98,15 @@ module.exports = function (source) {
       return callback(error)
     }
 
+    // Skip prettifying in development.
+    const prettifiedRender = process.env.NODE_ENV === 'production'
+      ? prettifyRender(render)
+      : render
+
     const highlightedSource = highlightSource(source)
 
     this.emitFile(`${outputName}/index.html`, generateIndex())
-    this.emitFile(`${outputName}/render.html`, prettifyRender(render))
+    this.emitFile(`${outputName}/render.html`, prettifiedRender)
     this.emitFile(`${outputName}/source.html`, highlightedSource)
 
     callback(null, '')

diff --git a/test/unit/lib/utils/fixtures/ugly.html b/test/unit/lib/utils/fixtures/ugly.html
@@ -18,7 +18,10 @@
           <img
   alt="Lorem ipsum dolor sit amet"
 src=""
-  class="js-different-thing-img"
+  class="hello
+    world
+
+  js-different-thing-img"
 
 
   width="800" height="451"

diff --git a/test/unit/lib/utils/snapshots/prettify-render.spec.js.md b/test/unit/lib/utils/snapshots/prettify-render.spec.js.md
@@ -26,7 +26,10 @@ Generated by [AVA](https://ava.li).
         <img␊
           alt="Lorem ipsum dolor sit amet"␊
           src=""␊
-          class="js-different-thing-img"␊
+          class="hello␊
+        world␊
+    ␊
+      js-different-thing-img"␊
           width="800"␊
           height="451"␊
         />␊

diff --git a/test/unit/lib/utils/snapshots/prettify-render.spec.js.snap b/test/unit/lib/utils/snapshots/prettify-render.spec.js.snap