This repository has been archived by the owner on Jul 17, 2019. It is now read-only.
display the messages in a table in the app #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1 second and I'll update this to use the rounded images added in #14 |
|
better imo ^^ |
|
Thanks @jurre I'm gonna take your changes and massage them a bit and then merge them in. |
|
Sure thing, let me know if there's anything I can do to help! (I removed some provisioning details from the project file, sorry about those) |
|
Ok this has been merged in |
|
awesome, thanks! |
|
@foozmeat did you end up needing to change a lot? |
|
I thought I was going to make some UI changes but decided to wait. I just pulled out the code signing changes in the project file mostly. |
|
I see, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We really enjoy using the messages feature and thought it would be nice to be able to see them in the app as well. There is an accompanying PR on the server as well.
This is what it looks like now:
I've pulled out some common code into
PCTableViewControllerthat both thePCStatusTableViewControllerand the newPCMessagesTableViewControlleruse, I was considering pulling out some of the data fetching code into it's own class as well since there is some duplication there now but I figured it was still small enough. Let me know if you'd prefer that though!