It's not much, but it helps #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
content_script.js will now skip over all <input>s and <textarea>s, as well as any Ace Editors on the page.
panicsteve
added a commit
that referenced
this pull request
Feb 29, 2016
content_script.js will now skip over all <input>s and <textarea>s, as well as any Ace Editors on the page.
|
Thanks! I don't know why I didn't see this PR earlier. |
|
No problem, just doing what I can to help. Although, looking back at my code now, I'm not quite sure why I used a |
|
I have changed it to a return. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
content_script.jswill now skip over all<input>s and<textarea>s, as well as any Ace Editors on the page.This will help with online editors, so that the script won't replace 'The Cloud' when loading a file to edit.
A couple examples of when this might help:
Also,
