Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: improve comments on Conn and test cases #471

Merged
merged 4 commits into from
May 24, 2023
Merged

opt: improve comments on Conn and test cases #471

merged 4 commits into from
May 24, 2023

Conversation

panjf2000
Copy link
Owner

No description provided.

@panjf2000 panjf2000 added this to the v2.3.0 milestone May 24, 2023
@panjf2000 panjf2000 self-assigned this May 24, 2023
@github-actions github-actions bot added the enhancement New feature or request label May 24, 2023
@panjf2000 panjf2000 added the optimization Some small optimizations label May 24, 2023
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: -0.08 ⚠️

Comparison is base (b341103) 77.04% compared to head (9af57b2) 76.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #471      +/-   ##
==========================================
- Coverage   77.04%   76.97%   -0.08%     
==========================================
  Files          23       23              
  Lines        2418     2445      +27     
==========================================
+ Hits         1863     1882      +19     
- Misses        423      429       +6     
- Partials      132      134       +2     
Flag Coverage Δ
unittests 76.97% <60.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
connection_unix.go 71.20% <0.00%> (ø)
connection_windows.go 64.52% <0.00%> (ø)
gnet.go 86.02% <ø> (+2.20%) ⬆️
reactor_default_bsd.go 87.14% <ø> (-0.19%) ⬇️
reactor_default_linux.go 82.02% <ø> (-0.20%) ⬇️
reactor_optimized_bsd.go 80.85% <ø> (-0.40%) ⬇️
reactor_optimized_linux.go 80.85% <ø> (-0.40%) ⬇️
listener_windows.go 78.57% <63.63%> (-9.36%) ⬇️
client_unix.go 58.06% <100.00%> (+0.27%) ⬆️
client_windows.go 79.59% <100.00%> (+0.13%) ⬆️
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@panjf2000 panjf2000 merged commit f6de680 into dev May 24, 2023
51 of 53 checks passed
@panjf2000 panjf2000 deleted the code-opt branch May 24, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request optimization Some small optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant