-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Python3 #7
Comments
We recognized there already have been numerous contributions to bring the original
So, after the migration and refactoring has settled a bit and produced a reasonably stable program right now, we would love to get respective contributions to finally be able to run this program on Python 3. The original contributions will not be helpful here as the refactoring went pretty far including modularizing the code, switching from FTP to HTTP and some other things we already have been working on. We are sorry for that mismatch and that we haven't been able to cherry-pick the respective improvements beforehand. Bottom lineSo,
Contributions to that are very much appreciated. With kind regards, |
Dear @Noordsestern, we can see you are already working on [1] - thank's for that! We just wanted to let you know you should probably always add the Good luck with further Python3-porting, we appreciate your work on that and will be happy about the outcome. With kind regards, |
What versions of Python does the library currently target? There are a number of code optimizations (some already laid out in the comments) which could be introduced if the library is 3.X+. Given that 2.7 is nearly totally deprecated and this is library is still in beta, it seems reasonable to move to Python 3 only, which leads to the question, can we limit support to 3.7+? |
Dear Jeremiah, supporting 3.7+ is totally reasonable and dropping support for 2.7 is long overdue. Please go ahead, we appreciate your work on that very much. With kind regards, |
Can't tell. But I'd say go with it and if anything incompatible comes up, we fix it :) unittests might be good in any case, though. |
Hi there, while working on #17, we have been running With kind regards, [1] |
Hey there, At first glance, this seems to be solvable. I will have a look into it anyway (as soon as there is time, bit busy right now), but just wanted to let you know. |
Dear @mmaelicke, thanks for writing in. I've just tried it again on CPython 3.7.4 and CPython 3.8.0 on macOS and importing
It makes me sad that it would not work for you out of the box on Windows for some reason. Maybe this is related to Anaconda in any way? Can I humbly ask you to share this output with us?
With kind regards, |
Dear Mirko,
[1] tells us that Can I ask you how you actually installed With kind regards, [1] https://build.opensuse.org/package/view_file/openSUSE:Factory/python-python-dateutil/python-python-dateutil.changes |
Hi again, 8df0f3d relaxes things a bit, I've just pushed With kind regards, |
Hey Andreas, Back on my actual working machine, using Linux, there are no issues in installing dwdweather2 and downloading some random data (following examples in the readme). Can confirm for Py36 and Py37, here. On the windows machine, I have a stupid dependency on |
Just saw the last commit, I will look into that as well, thanks! |
Dear Mirko,
With kind regards, [1] https://github.com/panodata/dwdweather2/blob/0.12.1/setup.py#L60 |
That's super-convenient, thank you Andreas. |
The minimum requirement has been bumped to Python 3.3, so I am closing this. Anyone experiencing issues under Python 3, please reopen this. |
@Noordsestern asked over at #5
The text was updated successfully, but these errors were encountered: