added an optional buffer-zone to nearest_station #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The buffer zone let's you get more stations, that are nearby and not just the nearest. It's optional and won't change existing methods. Output is a list of stations.
|
Thanks a bunch! Do you actually see that would solve #14 in any way so that we could close this issue? |
|
No problem! Hm.. did not look at the issue until now. It at least gives you more stations nearby to try, but does not filter them by the available sensor data. This would need another method. |
amotl
added a commit
that referenced
this pull request
Nov 4, 2019
|
Dear @stianchris, so let's keep #14 open then. However, may I humbly ask whether your implementation solves #3 already? If so, we could close that issue. Thanks already and with kind regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buffer zone let's you get more stations, that are nearby and not just the nearest.
It's optional and won't change existing methods.
Output is a list of stations.