Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved weather safety wait loop #1244

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Improved weather safety wait loop #1244

merged 3 commits into from
Apr 16, 2024

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented Apr 16, 2024

  • Use wait_delay from the config.
  • Formatting.

@wtgee wtgee self-assigned this Apr 16, 2024
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 35.71429% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 71.99%. Comparing base (ebb51ec) to head (b7960e2).

Files Patch % Lines
src/panoptes/pocs/utils/logger.py 0.00% 14 Missing and 1 partial ⚠️
src/panoptes/pocs/state/machine.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1244      +/-   ##
===========================================
- Coverage    72.00%   71.99%   -0.02%     
===========================================
  Files          101      101              
  Lines         8387     8390       +3     
  Branches      1188      876     -312     
===========================================
+ Hits          6039     6040       +1     
- Misses        2192     2194       +2     
  Partials       156      156              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Use `wait_delay` from the config.
Decide on the cloud logger from the config.
@wtgee wtgee merged commit 2a8b019 into develop Apr 16, 2024
10 of 11 checks passed
@wtgee wtgee deleted the wait-for-weather branch April 16, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant