Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cloud Logging from auto run. #1245

Merged
merged 11 commits into from
Apr 16, 2024
Merged

Fix Cloud Logging from auto run. #1245

merged 11 commits into from
Apr 16, 2024

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented Apr 16, 2024

  • Cloud logging is decided from the config rather than env vars.
  • Param passed to get_logger(use_cloud_logging=True)
  • Can force DEBUG level from cli with pocs run --cloud-logging run.
  • Put unit_id into cloud log.

Pulled from #1244.

Decide on the cloud logger from the config.
@wtgee wtgee self-assigned this Apr 16, 2024
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 21.95122% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 71.98%. Comparing base (ebb51ec) to head (314ee36).

❗ Current head 314ee36 differs from pull request most recent head 1ba4715. Consider uploading reports for the commit 1ba4715 to get more accurate results

Files Patch % Lines
src/panoptes/pocs/utils/logger.py 0.00% 19 Missing and 1 partial ⚠️
src/panoptes/pocs/core.py 45.45% 6 Missing ⚠️
src/panoptes/pocs/utils/cli/run.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1245      +/-   ##
===========================================
- Coverage    72.00%   71.98%   -0.02%     
===========================================
  Files          101      101              
  Lines         8387     8389       +2     
  Branches      1188     1187       -1     
===========================================
  Hits          6039     6039              
- Misses        2192     2195       +3     
+ Partials       156      155       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wtgee wtgee merged commit 507ba47 into develop Apr 16, 2024
10 checks passed
@wtgee wtgee deleted the fix-cloud-logging-03 branch April 16, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant