Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gphoto2 CAPTURECOMPLETE event #1255

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented May 6, 2024

This just replaces a hard-coded time wait with the official event notice.

Closes #122

Might help #489

* This just replaces a hard-coded time wait with the official event notice.
@wtgee wtgee self-assigned this May 6, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.69%. Comparing base (4092f40) to head (a8040ec).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1255      +/-   ##
===========================================
+ Coverage    70.19%   71.69%   +1.49%     
===========================================
  Files          100      100              
  Lines         8401     8401              
  Branches      1165     1165              
===========================================
+ Hits          5897     6023     +126     
+ Misses        2354     2229     -125     
+ Partials       150      149       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wtgee wtgee merged commit 4ec2240 into develop May 6, 2024
7 checks passed
@wtgee wtgee deleted the use-capturecomplete-event branch May 6, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explore gphoto2 CAPTURECOMPLETE event
1 participant