-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mdev.sh to hooks_lxc-mount.d #72
base: master
Are you sure you want to change the base?
Conversation
fa767c4
to
90bfee5
Compare
@@ -0,0 +1,17 @@ | |||
#!/bin/sh | |||
|
|||
container_mdev=/storage/trails/current/$LXC_NAME/mdev.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thinking about appengine, are all these script going to work if stuff is no longer in /storage or in /lib/pv?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats the best practice here? IMO we should path an env that folks can use to find the 'step" dir? what do we provide such hooks so they can do the right thing in appengine and here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we could set those variables from pantavisor that would be great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to inject then special envs in lxccontainer with the important paths so the hooks can refer to those VARs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets add PV_STORAGE_DIR env
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets discuss :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now we use /storage as default for appengine. In the end is just about if we want to support a path different than /storage or if we want to support this feature in appengine too.
3b664dc
to
6b8f47f
Compare
To use this put a mdev.json in your platform folder, e.g. for a container named "busy" you could do: