Skip to content
This repository has been archived by the owner on Aug 8, 2024. It is now read-only.

Update composer.json for Composer 2 compatibility. #405

Merged
merged 4 commits into from
Oct 6, 2020

Conversation

greg-1-anderson
Copy link
Member

This is a start. This composer.json does update, but still contains the following warnings:

Class Symfony\Cmf\Component\Routing\Tests\Mapper\FieldMapEnhancerTest located in ./vendor/symfony-cmf/routing/Tests/Enhancer/FieldMapEnhancerTest.php does not comply with psr-4 autoloading standard. Skipping.
Class Symfony\Cmf\Component\Routing\PagedRouteCollectionTest located in ./vendor/symfony-cmf/routing/Tests/Routing/PagedRouteCollectionTest.php does not comply with psr-4 autoloading standard. Skipping.
Class Symfony\Cmf\Component\Routing\LazyRouteCollectionTest located in ./vendor/symfony-cmf/routing/Tests/Routing/LazyRouteCollectionTest.php does not comply with psr-4 autoloading standard. Skipping.
Class EasyRdf_Serialiser_JsonLd located in ./vendor/easyrdf/easyrdf/lib/EasyRdf/Serialiser/JsonLd_real.php does not comply with psr-0 autoloading standard. Skipping.
Class EasyRdf_Parser_JsonLd located in ./vendor/easyrdf/easyrdf/lib/EasyRdf/Parser/JsonLdImplementation.php does not comply with psr-0 autoloading standard. Skipping.
Class Drush\CommandFiles\Core\BrowseCommands located in ./vendor/drush/drush/lib/Drush/CommandFiles/core/browseCommands.php does not comply with psr-0 autoloading standard. Skipping.

Hm, I am wondering if we will need to go up to Drupal 9 to clear up the Symfony problems. Trying that next.

@greg-1-anderson
Copy link
Member Author

greg-1-anderson commented Oct 1, 2020

Sure enough, upgrading to Drupal 9 cleared up the Symfony warnings. These are only test files, though, and therefore these warnings are innocuous. Leaving this project at Drupal 8 for now, since this is, after all, "example-drops-8-composer".

I dropped rvtraveller/qs-composer-installer. We have rvtraveller/qs-composer-installer#3, but at first blush, only the author seems to be using this plugin. It is possible that others might be using qs scripts provided by the author, or might be using it with scripts not published on Packagist. Impact of dropping this is low, I think.

I also dropped zaporylie/composer-drupal-optimizations. This is unnecessary with Composer 2, and only provides minimal improvements with Composer 1. Dropping this dependency will simplify our move to Composer 2.

At this point, the only thing we need before we could merge here is cweagans/composer-patches#332. Once we have that, we can bump our cweagans/composer-patches version constraint to ^1.7 (it will probably be).

@greg-1-anderson
Copy link
Member Author

@sugaroverflow FYI

@greg-1-anderson
Copy link
Member Author

Works. Recommend merging and tagging.

Copy link

@sugaroverflow sugaroverflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The process and updates make sense to me 👍 ready for merge

@greg-1-anderson greg-1-anderson merged commit 83c0cb6 into master Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants