Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Missing function namespace in reference #50

Closed
al-esc opened this issue Jun 14, 2024 · 0 comments · Fixed by #48
Closed

Bug: Missing function namespace in reference #50

al-esc opened this issue Jun 14, 2024 · 0 comments · Fixed by #48

Comments

@al-esc
Copy link
Contributor

al-esc commented Jun 14, 2024

Object cache checks added to the Site Health page reference the function test_object_cache, linked below, without its relevant namespace. As such, Object Cache tests are not checked nor outputted in the Site Health Info tab.

'test' => 'test_object_cache',


Resolution is to include the file namespace:

/**
 * Add object cache tests.
 *
 * @param array $tests The Site Health tests.
 *
 * @return array
 */
function object_cache_tests( $tests ) {
	$tests['direct']['object_cache'] = [
		'label' => __( 'Object Cache', 'pantheon' ),
		'test'  => __NAMESPACE__ . '\\test_object_cache',
	];

	return $tests;
}
al-esc added a commit to crowdfavorite/pantheon-mu-plugin that referenced this issue Jul 17, 2024
jazzsequence added a commit that referenced this issue Jul 29, 2024
* Feature: Add compatibility layer logic and status output.

* qa/address review comments

* qa/cleanup

* qa/code-style

* qa/code style; feat/output compatibility status to main site health tab

* fix linting regressions

* refactor plugin name retrieval

* i18n missed string

* update phpdoc on Base class constructor

* GH-50/fix missing function namespace

* linting

---------

Co-authored-by: Chris Reynolds <chris@jazzsequence.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant