Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Relay via WP_REDIS_USE_RELAY #344

Merged
merged 2 commits into from
Feb 18, 2022

Conversation

tillkruss
Copy link
Contributor

Added support for Relay via WP_REDIS_USE_RELAY constant.

I used a constant instead of wp_redis_prepare_client_connection_callback, since it's a drop-in replacement for PhpRedis with an identical API.

@danielbachhuber
Copy link
Contributor

@tillkruss Got the go-ahead from the internal team, with one request:

Can you request information on how end users get support from Relay. We'd like to see the capability and link to access support added in the README.

You can include it in *Installation, after the mention of Human Made's adaptor: https://github.com/pantheon-systems/wp-redis#installation

also link Redis hash expiration issue
@tillkruss
Copy link
Contributor Author

@danielbachhuber Thanks for following up. I've added the requested notes in ddee391.

@danielbachhuber danielbachhuber added this to the 1.2.0 milestone Feb 18, 2022
Copy link
Contributor

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @tillkruss !

@danielbachhuber danielbachhuber merged commit 61ea059 into pantheon-systems:master Feb 18, 2022
@tillkruss tillkruss deleted the patch-3 branch February 18, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants