-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGS-6127] Add support for flush_runtime and flush_group #405
Conversation
@jspellman814 this closes #366 as well, correct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once tests included.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@jspellman814, I bumped the minor version number per the new policy in CONTRIBUTING.md, please make sure I caught all instances and you're onboard with the change.
Makes me think perhaps we should use the same in the changelog headings as well (instead of ### Latest ###
), but that's a conversation for elsewhere.
Addresses #399.